Fix : Announcing static addresses for mDNS #3096
Closed
MOHANKUMAR-IT wants to merge 12 commits intolibp2p:masterfrom
Closed
Fix : Announcing static addresses for mDNS #3096MOHANKUMAR-IT wants to merge 12 commits intolibp2p:masterfrom
MOHANKUMAR-IT wants to merge 12 commits intolibp2p:masterfrom
Conversation
- Subscribe to local address update events from libp2p host - On address change, shut down the existing mDNS server and re-register with updated address
- Subscribe to local address update events from libp2p host - On address change, shut down the existing mDNS server and re-register with updated address
Collaborator
|
Did you manage to test that this works for you? I wonder if we have to start the resolver as well. |
Collaborator
|
I think we do need to restart the resolver as well. Could you please add a test case as well? |
Author
|
I'll also add a test case to ensure the behavior is covered and working as expected. Thank you for pointing it out! |
Collaborator
|
Automatically closing old open PRs. If you're still interested in merging this please open the PR again and rebase from the latest master, otherwise do nothing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-register proxy on local address change event from libp2p host
FIxes : #1163